Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: filter/dscache/ds_txn.go

Issue 1355783002: Refactor keys and queries in datastore service and implementation. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: appease errcheck Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « filter/dscache/ds.go ('k') | filter/dscache/ds_txn_state.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package dscache 5 package dscache
6 6
7 import ( 7 import (
8 ds "github.com/luci/gae/service/datastore" 8 ds "github.com/luci/gae/service/datastore"
9 ) 9 )
10 10
11 type dsTxnCache struct { 11 type dsTxnCache struct {
12 ds.RawInterface 12 ds.RawInterface
13 13
14 state *dsTxnState 14 state *dsTxnState
15 15
16 sc *supportContext 16 sc *supportContext
17 } 17 }
18 18
19 var _ ds.RawInterface = (*dsTxnCache)(nil) 19 var _ ds.RawInterface = (*dsTxnCache)(nil)
20 20
21 func (d *dsTxnCache) DeleteMulti(keys []ds.Key, cb ds.DeleteMultiCB) error { 21 func (d *dsTxnCache) DeleteMulti(keys []*ds.Key, cb ds.DeleteMultiCB) error {
22 d.state.add(d.sc, keys) 22 d.state.add(d.sc, keys)
23 return d.RawInterface.DeleteMulti(keys, cb) 23 return d.RawInterface.DeleteMulti(keys, cb)
24 } 24 }
25 25
26 func (d *dsTxnCache) PutMulti(keys []ds.Key, metas []ds.PropertyMap, cb ds.PutMu ltiCB) error { 26 func (d *dsTxnCache) PutMulti(keys []*ds.Key, metas []ds.PropertyMap, cb ds.PutM ultiCB) error {
27 d.state.add(d.sc, keys) 27 d.state.add(d.sc, keys)
28 return d.RawInterface.PutMulti(keys, metas, cb) 28 return d.RawInterface.PutMulti(keys, metas, cb)
29 } 29 }
30 30
31 // TODO(riannucci): on GetAll, Load from memcache and invalidate entries if the 31 // TODO(riannucci): on GetAll, Load from memcache and invalidate entries if the
32 // memcache version doesn't match the datastore version. 32 // memcache version doesn't match the datastore version.
OLDNEW
« no previous file with comments | « filter/dscache/ds.go ('k') | filter/dscache/ds_txn_state.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698