Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1355753008: RuntimeEnabledFeatures::slimmingPaintOffsetCaching (Closed)

Created:
5 years, 3 months ago by Xianzhu
Modified:
5 years, 3 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

RuntimeEnabledFeatures::slimmingPaintOffsetCaching Put paint offset caching code under this condition because we may enable it for slimming paint v1. Also add a test for bug 533277, and exclude paint-offset workaround when paint offset caching is enabled. BUG=508383, 533277 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202658

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 17 (8 generated)
Xianzhu
5 years, 3 months ago (2015-09-22 17:58:55 UTC) #2
pdr.
LGTM Can we try unittesting these in the future? (Layouttest is fine for this patch)
5 years, 3 months ago (2015-09-22 18:08:18 UTC) #3
Xianzhu
On 2015/09/22 18:08:18, pdr wrote: > LGTM > > Can we try unittesting these in ...
5 years, 3 months ago (2015-09-22 18:11:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355753008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355753008/20001
5 years, 3 months ago (2015-09-22 18:33:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/118576)
5 years, 3 months ago (2015-09-22 18:55:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355753008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355753008/40001
5 years, 3 months ago (2015-09-22 19:23:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/110694)
5 years, 3 months ago (2015-09-22 21:42:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355753008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355753008/40001
5 years, 3 months ago (2015-09-22 21:44:28 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 02:50:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202658

Powered by Google App Engine
This is Rietveld 408576698