Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1355753003: Allow keys with AltGr modifier to be inserted in Textfield (Closed)

Created:
5 years, 3 months ago by afakhry
Modified:
5 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tdresser+watch_chromium.org, tfarina, jam, nona+watch_chromium.org, darin-cc_chromium.org, shuchen+watch_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow keys with AltGr modifier to be inserted in Textfield AltGr modifier is used to type alternative keys on certain keyboard layouts so we don't consider keys with the AltGr modifier as a system key. R=oshima@chromium.org BUG=529883 Committed: https://crrev.com/3d96df64780723580da4c312557b8fc4622cfd35 Cr-Commit-Position: refs/heads/master@{#349680}

Patch Set 1 #

Patch Set 2 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M content/browser/renderer_host/native_web_keyboard_event_aura.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/events/base_event_utils.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
afakhry
Oshima, please take a look!
5 years, 3 months ago (2015-09-18 00:51:01 UTC) #1
oshima
can you add a unit test?
5 years, 3 months ago (2015-09-18 01:36:35 UTC) #2
afakhry
On 2015/09/18 01:36:35, oshima wrote: > can you add a unit test? Done!
5 years, 3 months ago (2015-09-18 02:06:05 UTC) #3
oshima
lgtm
5 years, 3 months ago (2015-09-18 02:15:38 UTC) #4
afakhry
avi@ Can you please take a look?
5 years, 3 months ago (2015-09-18 02:20:04 UTC) #6
Avi (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-18 03:01:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355753003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355753003/20001
5 years, 3 months ago (2015-09-18 15:53:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-18 16:00:32 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 16:01:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d96df64780723580da4c312557b8fc4622cfd35
Cr-Commit-Position: refs/heads/master@{#349680}

Powered by Google App Engine
This is Rietveld 408576698