Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1355673003: EDK: Add a MakeUnique and use it somewhere. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
jamesr, kulakowski
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add a MakeUnique and use it somewhere. (For use until we can use C++14.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b9dda656ce3a15c967088fd7fab01041d9a85f71

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -6 lines) Patch
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.h View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/system/endpoint_relayer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/system/endpoint_relayer_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
A mojo/edk/system/make_unique.h View 1 chunk +57 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
5 years, 3 months ago (2015-09-17 22:03:58 UTC) #1
jamesr
lgtm https://codereview.chromium.org/1355673003/diff/1/mojo/edk/system/make_unique.h File mojo/edk/system/make_unique.h (right): https://codereview.chromium.org/1355673003/diff/1/mojo/edk/system/make_unique.h#newcode12 mojo/edk/system/make_unique.h:12: // - It's been formatted. "It is been ...
5 years, 3 months ago (2015-09-17 22:07:49 UTC) #2
viettrungluu
On 2015/09/17 22:07:49, jamesr wrote: > lgtm > > https://codereview.chromium.org/1355673003/diff/1/mojo/edk/system/make_unique.h > File mojo/edk/system/make_unique.h (right): > ...
5 years, 3 months ago (2015-09-17 22:09:49 UTC) #3
viettrungluu
Committed patchset #1 (id:1) manually as b9dda656ce3a15c967088fd7fab01041d9a85f71 (presubmit successful).
5 years, 3 months ago (2015-09-17 22:10:35 UTC) #4
kulakowski
5 years, 3 months ago (2015-09-17 22:12:15 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1355673003/diff/1/mojo/edk/system/make_unique.h
File mojo/edk/system/make_unique.h (right):

https://codereview.chromium.org/1355673003/diff/1/mojo/edk/system/make_unique...
mojo/edk/system/make_unique.h:26: struct _Unique_if {
Nit: Identifiers starting with an underscore followed by a capital letter are
reserved for the implementation. In practice it's probably fine.

Powered by Google App Engine
This is Rietveld 408576698