Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1355563003: Devtools: Rename InspectorOverlayImpl to InspectorOverlay (Closed)

Created:
5 years, 3 months ago by sergeyv
Modified:
5 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Rename InspectorOverlayImpl to InspectorOverlay BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202650

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1005 lines) Patch
A + Source/web/InspectorOverlay.h View 6 chunks +13 lines, -13 lines 0 comments Download
A + Source/web/InspectorOverlay.cpp View 32 chunks +55 lines, -55 lines 0 comments Download
D Source/web/InspectorOverlayImpl.h View 1 chunk +0 lines, -174 lines 0 comments Download
D Source/web/InspectorOverlayImpl.cpp View 1 chunk +0 lines, -745 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
sergeyv
5 years, 3 months ago (2015-09-22 00:53:28 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1355563003/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/1355563003/diff/1/Source/web/WebViewImpl.cpp#newcode503 Source/web/WebViewImpl.cpp:503: return static_cast<InspectorOverlay*>(devtools->overlay()); Remove the cast.
5 years, 3 months ago (2015-09-22 03:07:36 UTC) #3
sergeyv
https://codereview.chromium.org/1355563003/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/1355563003/diff/1/Source/web/WebViewImpl.cpp#newcode503 Source/web/WebViewImpl.cpp:503: return static_cast<InspectorOverlay*>(devtools->overlay()); On 2015/09/22 03:07:36, dgozman wrote: > Remove ...
5 years, 3 months ago (2015-09-22 16:55:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355563003/20001
5 years, 3 months ago (2015-09-22 16:55:56 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 19:35:59 UTC) #8
sergeyv
@pfeldman, can you please take a look? I need web/ owner lgtm
5 years, 3 months ago (2015-09-22 20:41:36 UTC) #9
pfeldman
lgtm
5 years, 3 months ago (2015-09-22 23:25:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355563003/20001
5 years, 3 months ago (2015-09-22 23:31:22 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 23:42:43 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202650

Powered by Google App Engine
This is Rietveld 408576698