Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: snapshot/win/pe_image_annotations_reader.cc

Issue 1355503005: win: Make reading CrashpadInfo work across bitness (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: nt_headers Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Crashpad Authors. All rights reserved. 1 // Copyright 2015 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "snapshot/win/pe_image_annotations_reader.h" 15 #include "snapshot/win/pe_image_annotations_reader.h"
16 16
17 #include <string.h> 17 #include <string.h>
18 18
19 #include "base/strings/utf_string_conversions.h" 19 #include "base/strings/utf_string_conversions.h"
20 #include "client/simple_string_dictionary.h" 20 #include "client/simple_string_dictionary.h"
21 #include "snapshot/win/pe_image_reader.h" 21 #include "snapshot/win/pe_image_reader.h"
22 #include "snapshot/win/process_reader_win.h" 22 #include "snapshot/win/process_reader_win.h"
23 #include "util/win/process_structs.h"
23 24
24 namespace crashpad { 25 namespace crashpad {
25 26
26 PEImageAnnotationsReader::PEImageAnnotationsReader( 27 PEImageAnnotationsReader::PEImageAnnotationsReader(
27 ProcessReaderWin* process_reader, 28 ProcessReaderWin* process_reader,
28 const PEImageReader* pe_image_reader, 29 const PEImageReader* pe_image_reader,
29 const std::wstring& name) 30 const std::wstring& name)
30 : name_(name), 31 : name_(name),
31 process_reader_(process_reader), 32 process_reader_(process_reader),
32 pe_image_reader_(pe_image_reader) { 33 pe_image_reader_(pe_image_reader) {
33 } 34 }
34 35
35 std::map<std::string, std::string> PEImageAnnotationsReader::SimpleMap() const { 36 std::map<std::string, std::string> PEImageAnnotationsReader::SimpleMap() const {
36 std::map<std::string, std::string> simple_map_annotations; 37 std::map<std::string, std::string> simple_map_annotations;
37 ReadCrashpadSimpleAnnotations(&simple_map_annotations); 38 if (process_reader_->Is64Bit()) {
39 ReadCrashpadSimpleAnnotations<process_types::internal::Traits64>(
40 &simple_map_annotations);
41 } else {
42 ReadCrashpadSimpleAnnotations<process_types::internal::Traits32>(
43 &simple_map_annotations);
44 }
38 return simple_map_annotations; 45 return simple_map_annotations;
39 } 46 }
40 47
48 template <class Traits>
41 void PEImageAnnotationsReader::ReadCrashpadSimpleAnnotations( 49 void PEImageAnnotationsReader::ReadCrashpadSimpleAnnotations(
42 std::map<std::string, std::string>* simple_map_annotations) const { 50 std::map<std::string, std::string>* simple_map_annotations) const {
43 process_types::CrashpadInfo crashpad_info; 51 process_types::CrashpadInfo<Traits> crashpad_info;
44 if (!pe_image_reader_->GetCrashpadInfo(&crashpad_info)) 52 if (!pe_image_reader_->GetCrashpadInfo(&crashpad_info))
45 return; 53 return;
46 54
47 if (!crashpad_info.simple_annotations) 55 if (!crashpad_info.simple_annotations)
48 return; 56 return;
49 57
50 std::vector<SimpleStringDictionary::Entry> 58 std::vector<SimpleStringDictionary::Entry>
51 simple_annotations(SimpleStringDictionary::num_entries); 59 simple_annotations(SimpleStringDictionary::num_entries);
52 if (!process_reader_->ReadMemory( 60 if (!process_reader_->ReadMemory(
53 crashpad_info.simple_annotations, 61 crashpad_info.simple_annotations,
(...skipping 11 matching lines...) Expand all
65 std::string value(entry.value, strnlen(entry.value, sizeof(entry.value))); 73 std::string value(entry.value, strnlen(entry.value, sizeof(entry.value)));
66 if (!simple_map_annotations->insert(std::make_pair(key, value)).second) { 74 if (!simple_map_annotations->insert(std::make_pair(key, value)).second) {
67 LOG(INFO) << "duplicate simple annotation " << key << " in " 75 LOG(INFO) << "duplicate simple annotation " << key << " in "
68 << base::UTF16ToUTF8(name_); 76 << base::UTF16ToUTF8(name_);
69 } 77 }
70 } 78 }
71 } 79 }
72 } 80 }
73 81
74 } // namespace crashpad 82 } // namespace crashpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698