Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 135543002: Explicitly cut link between WebViewPlugin and PluginPlaceholder (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
Bernhard Bauer, inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Explicitly cut link between WebViewPlugin and PluginPlaceholder BUG=332675 R=bauerb@chromium.org,inferno@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244487

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M components/plugins/renderer/plugin_placeholder.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M components/plugins/renderer/webview_plugin.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review
6 years, 11 months ago (2014-01-13 08:08:22 UTC) #1
Bernhard Bauer
lgtm
6 years, 11 months ago (2014-01-13 09:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/135543002/1
6 years, 11 months ago (2014-01-13 09:54:34 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 12:04:17 UTC) #4
Message was sent while issue was closed.
Change committed as 244487

Powered by Google App Engine
This is Rietveld 408576698