Devtools: initialize protocol enums synchronously

Source/devtools/front_end/sdk/InspectorBackend.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  */
 function InspectorBackendClass()
 {
-    this._connection = null;
     this._agentPrototypes = {};
     this._dispatcherPrototypes = {};
     this._initialized = false;
-    this._enums = {};
     this._initProtocolAgentsConstructor();
 }
 
 InspectorBackendClass._DevToolsErrorCode = -32000;
 
 /**
  * @param {string} error
  * @param {!Object} messageObject
  */
 InspectorBackendClass.reportProtocolError = function(error, messageObject)
@@ skipping 42 matching lines @@
          */
         function registerDispatcher(dispatcher)
         {
             this.registerDispatcher(domain, dispatcher)
         }
 
         window.Protocol.Agents.prototype["register" + domain + "Dispatcher"] = registerDispatcher;
     },
 
     /**
-     * @return {!InspectorBackendClass.Connection}
-     */
-    connection: function()
-    {
-        if (!this._connection)
-            throw "Main connection was not initialized";
-        return this._connection;
-    },
-
-    /**
-     * @param {!InspectorBackendClass.MainConnection} connection
-     */
-    setConnection: function(connection)
-    {
-        this._connection = connection;
-
-        this._connection.registerAgentsOn(window);
-        for (var type in this._enums) {
-            var domainAndMethod = type.split(".");
-            window[domainAndMethod[0] + "Agent"][domainAndMethod[1]] = this._enums[type];
-        }
-    },
-
-    /**
      * @param {string} domain
      * @return {!InspectorBackendClass.AgentPrototype}
      */
     _agentPrototype: function(domain)
     {
         if (!this._agentPrototypes[domain]) {
             this._agentPrototypes[domain] = new InspectorBackendClass.AgentPrototype(domain);
             this._addAgentGetterMethodToProtocolAgentsPrototype(domain);
         }
 
@@ skipping 23 matching lines @@
         this._agentPrototype(domainAndMethod[0]).registerCommand(domainAndMethod[1], signature, replyArgs, hasErrorData);
         this._initialized = true;
     },
 
     /**
      * @param {string} type
      * @param {!Object} values
      */
     registerEnum: function(type, values)
     {
-        this._enums[type] = values;
+        var domainAndMethod = type.split(".");
+        var agentName = domainAndMethod[0] + "Agent";
+        if (!window[agentName])
+            window[agentName] = {};
+
+        window[agentName][domainAndMethod[1]] = values;
         this._initialized = true;
     },
 
     /**
      * @param {string} eventName
      * @param {!Object} params
      */
     registerEvent: function(eventName, params)
     {
         var domain = eventName.split(".")[0];
@@ skipping 178 matching lines @@
             this._agents[domain] = Object.create(agentPrototypes[domain]);
             this._agents[domain].setConnection(this);
         }
 
         for (var domain in dispatcherPrototypes)
             this._dispatchers[domain] = Object.create(dispatcherPrototypes[domain]);
 
     },
 
     /**
-     * @param {!Object} object
-     */
-    registerAgentsOn: function(object)
-    {
-        for (var domain in this._agents)
-            object[domain + "Agent"]  = {};
-    },
-
-    /**
      * @return {number}
      */
     nextMessageId: function()
     {
         return this._lastMessageId++;
     },
 
     /**
      * @param {string} domain
      * @return {!InspectorBackendClass.AgentPrototype}
@@ skipping 661 matching lines @@
     }
 }
 
 InspectorBackendClass.Options = {
     dumpInspectorTimeStats: false,
     dumpInspectorProtocolMessages: false,
     suppressRequestErrors: false
 }
 
 InspectorBackend = new InspectorBackendClass();