Move error classification into the ssl_errors component

chrome/browser/ssl/bad_clock_blocking_page.cc

Index: chrome/browser/ssl/bad_clock_blocking_page.cc
diff --git a/chrome/browser/ssl/bad_clock_blocking_page.cc b/chrome/browser/ssl/bad_clock_blocking_page.cc
index 2d2f51d30adda3a1bd344897eee25ddfc22b9c72..e8baf9aca6aa648935a06060e7e5aaa4df7e6ba0 100644
--- a/chrome/browser/ssl/bad_clock_blocking_page.cc
+++ b/chrome/browser/ssl/bad_clock_blocking_page.cc
@@ -25,10 +25,10 @@
 #include "chrome/browser/renderer_preferences_util.h"
 #include "chrome/browser/ssl/cert_report_helper.h"
 #include "chrome/browser/ssl/ssl_cert_reporter.h"
-#include "chrome/browser/ssl/ssl_error_classification.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/google/core/browser/google_util.h"
+#include "components/ssl_errors/error_classification.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cert_store.h"
 #include "content/public/browser/interstitial_page.h"
@@ -199,9 +199,8 @@ BadClockBlockingPage::BadClockBlockingPage(
       false /* overridable */, metrics_helper()));
 
   // TODO(felt): Separate the clock statistics from the main ssl statistics.
-  SSLErrorClassification classifier(time_triggered_, request_url, cert_error_,
-                                    *ssl_info_.cert.get());
-  classifier.RecordUMAStatistics(false);
+  ssl_errors::RecordUMAStatistics(false, time_triggered_, request_url,

[estark, 2015/10/02 22:17:21]

nit: is the 'false' overridable? Can you either make this argument an enum or
add /* overridable */?

[felt, 2015/10/05 05:26:40]

I really hate putting comments inline, but this bool now appears in enough
places that an enum would make sense. But I also don't want to do a refactor for
that in this CL (there are many places where overridable status is passed), so
I'll do this in a followup cleanup pass.

+                                  cert_error_, *ssl_info_.cert.get());
 }
 
 bool BadClockBlockingPage::ShouldCreateNewNavigation() const {
@@ -244,10 +243,9 @@ void BadClockBlockingPage::PopulateInterstitialStrings(
   load_time_data->SetBoolean("hide_primary_button", false);
 #endif
 
-  int heading_string =
-      SSLErrorClassification::IsUserClockInTheFuture(time_triggered_)
-          ? IDS_CLOCK_ERROR_AHEAD_HEADING
-          : IDS_CLOCK_ERROR_BEHIND_HEADING;
+  int heading_string = ssl_errors::IsUserClockInTheFuture(time_triggered_)
+                           ? IDS_CLOCK_ERROR_AHEAD_HEADING
+                           : IDS_CLOCK_ERROR_BEHIND_HEADING;
 
   load_time_data->SetString("tabTitle",
                             l10n_util::GetStringUTF16(IDS_CLOCK_ERROR_TITLE));