chrome/browser/ssl/ssl_error_handler.cc - Issue 1355413003: Move error classification into the ssl_errors component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_handler.cc

Issue 1355413003: Move error classification into the ssl_errors component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/ssl_blocking_page.cc ('K') | « chrome/browser/ssl/ssl_error_classification_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | components/ssl_errors/error_classification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_error_handler.cc

diff --git a/chrome/browser/ssl/ssl_error_handler.cc b/chrome/browser/ssl/ssl_error_handler.cc

index 7fe5d0251963a45e8dfff7775d061cf1f7665eb6..5085f9005f2d87682620ed2407ef8aef7cd2a06f 100644

--- a/chrome/browser/ssl/ssl_error_handler.cc

+++ b/chrome/browser/ssl/ssl_error_handler.cc

@@ -14,7 +14,7 @@

#include "chrome/browser/ssl/bad_clock_blocking_page.h"

#include "chrome/browser/ssl/ssl_blocking_page.h"

#include "chrome/browser/ssl/ssl_cert_reporter.h"

-#include "chrome/browser/ssl/ssl_error_classification.h"

+#include "components/ssl_errors/error_classification.h"

#include "components/ssl_errors/error_info.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

@@ -137,8 +137,8 @@ bool IsErrorDueToBadClock(const base::Time& now, int error) {

ssl_errors::ErrorInfo::CERT_DATE_INVALID) {

return false;

}

- return SSLErrorClassification::IsUserClockInThePast(now) ||

- SSLErrorClassification::IsUserClockInTheFuture(now);

+ return ssl_errors::ErrorClassification::IsUserClockInThePast(now) ||

+ ssl_errors::ErrorClassification::IsUserClockInTheFuture(now);

}

} // namespace