chrome/browser/ssl/ssl_browser_tests.cc - Issue 1355413003: Move error classification into the ssl_errors component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1355413003: Move error classification into the ssl_errors component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/ssl_blocking_page.cc ('K') | « chrome/browser/ssl/ssl_blocking_page.cc ('k') | chrome/browser/ssl/ssl_error_classification.h » ('j') | components/ssl_errors/error_classification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index b841c87b3343a68587b5ff1e1a78f297dd40ce74..25b8d391d1c25f3b59bf8173014993121d4fc650 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -31,7 +31,6 @@

#include "chrome/browser/ssl/common_name_mismatch_handler.h"

#include "chrome/browser/ssl/security_state_model.h"

#include "chrome/browser/ssl/ssl_blocking_page.h"

-#include "chrome/browser/ssl/ssl_error_classification.h"

#include "chrome/browser/ssl/ssl_error_handler.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

@@ -45,6 +44,7 @@

#include "chrome/test/base/ui_test_utils.h"

#include "components/content_settings/core/browser/host_content_settings_map.h"

#include "components/security_interstitials/core/metrics_helper.h"

+#include "components/ssl_errors/error_classification.h"

#include "components/variations/variations_associated_data.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

#include "content/public/browser/browser_context.h"

@@ -808,7 +808,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTPSErrorCausedByClock) {

mock_clock->SetNow(base::Time::NowFromSystemTime());

mock_clock->Advance(base::TimeDelta::FromDays(367));

SSLErrorHandler::SetClockForTest(mock_clock.get());

- SSLErrorClassification::SetBuildTimeForTesting(

+ ssl_errors::ErrorClassification::SetBuildTimeForTesting(

base::Time::NowFromSystemTime());

ui_test_utils::NavigateToURL(browser(), https_server_expired_.GetURL("/"));

@@ -2420,7 +2420,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest,

mock_clock.SetNow(base::Time::NowFromSystemTime());

mock_clock.Advance(base::TimeDelta::FromDays(367));

SSLErrorHandler::SetClockForTest(&mock_clock);

- SSLErrorClassification::SetBuildTimeForTesting(

+ ssl_errors::ErrorClassification::SetBuildTimeForTesting(

base::Time::NowFromSystemTime());

ui_test_utils::NavigateToURL(browser(), https_server_expired_.GetURL("/"));