Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6538)

Unified Diff: chrome/browser/ssl/common_name_mismatch_handler.cc

Issue 1355413003: Move error classification into the ssl_errors component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove size_t / int mixing Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/bad_clock_blocking_page.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/common_name_mismatch_handler.cc
diff --git a/chrome/browser/ssl/common_name_mismatch_handler.cc b/chrome/browser/ssl/common_name_mismatch_handler.cc
index 941127b7d95d4fda27dbc828fdcc54eb8cd93cd4..691bb0e2fb12fdca5786d3f1fbccd333ac349b7d 100644
--- a/chrome/browser/ssl/common_name_mismatch_handler.cc
+++ b/chrome/browser/ssl/common_name_mismatch_handler.cc
@@ -7,7 +7,7 @@
#include "base/callback_helpers.h"
#include "base/logging.h"
#include "base/strings/string_number_conversions.h"
-#include "chrome/browser/ssl/ssl_error_classification.h"
+#include "components/ssl_errors/error_classification.h"
#include "net/base/load_flags.h"
#include "net/http/http_response_headers.h"
#include "net/http/http_util.h"
@@ -54,10 +54,9 @@ bool CommonNameMismatchHandler::GetSuggestedUrl(
const GURL& request_url,
const std::vector<std::string>& dns_names,
GURL* suggested_url) {
- std::string host_name = request_url.host();
std::string www_mismatch_hostname;
- if (!SSLErrorClassification::GetWWWSubDomainMatch(host_name, dns_names,
- &www_mismatch_hostname)) {
+ if (!ssl_errors::GetWWWSubDomainMatch(request_url, dns_names,
+ &www_mismatch_hostname)) {
return false;
}
// The full URL should be pinged, not just the new hostname. So, get the
« no previous file with comments | « chrome/browser/ssl/bad_clock_blocking_page.cc ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698