[sql] Disable mmap test under mojo.

[sql] Disable mmap test under mojo.

Not appropriate for mojo.

BUG=489784

[Scott Hess - ex-Googler, 2015-09-23 21:32:30]

shess@chromium.org changed reviewers:
+ erg@chromium.org

[Scott Hess - ex-Googler, 2015-09-23 21:32:31]

This test tests that memory-mapping works right, but it's going to fail badly in
a sandbox.

Once I figure out how to build mojo, I'll circle back with a CL to disable mmap
internally, if needed.  I suspect that right now it's calling xFetch() and
failing, so it works, but could be better.

https://codereview.chromium.org/1355403004/diff/1/sql/connection_unittest.cc
File sql/connection_unittest.cc (right):

https://codereview.chromium.org/1355403004/diff/1/sql/connection_unittest.cc#...
sql/connection_unittest.cc:1332: ASSERT_TRUE(f.IsValid());
Things start breaking here under Mojo.  Which seems reasonable to me.

[Elliot Glaysher, 2015-09-23 21:36:48]

lgtm

[Scott Hess - ex-Googler, 2015-09-23 21:38:09]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2015-09-23 21:38:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1355403004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1355403004/1

[jbroman, 2015-09-23 22:36:57]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2015-09-23 22:38:26]

On 2015/09/23 at 21:38:44, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1355403004/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1355403004/1

Pulled this out of the CQ because I'm reverting the CL which added this test
(due to MSAN failures): https://codereview.chromium.org/1365783002/

[Scott Hess - ex-Googler, 2015-09-23 22:39:24]

Sure.  I'll slipstream it when I reland.

On Wed, Sep 23, 2015 at 3:38 PM, <jbroman@chromium.org> wrote:

> On 2015/09/23 at 21:38:44, commit-bot wrote:
>
>> CQ is trying da patch. Follow status at
>>   https://chromium-cq-status.appspot.com/patch-status/1355403004/1
>> View timeline at
>>   https://chromium-cq-status.appspot.com/patch-timeline/1355403004/1
>>
>
> Pulled this out of the CQ because I'm reverting the CL which added this
> test
> (due to MSAN failures): https://codereview.chromium.org/1365783002/
>
> https://codereview.chromium.org/1355403004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.