Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: services/files/shared_impl.cc

Issue 1355403002: enum class fixups - testing non-zero (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« services/files/file_impl.cc ('K') | « services/files/file_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/files/shared_impl.cc
diff --git a/services/files/shared_impl.cc b/services/files/shared_impl.cc
index 8584f82d108121c42c2499e916e5b29653137834..24cdc3be642f8fd51a65c0534edaf2006a3f68b7 100644
--- a/services/files/shared_impl.cc
+++ b/services/files/shared_impl.cc
@@ -59,12 +59,15 @@ void TouchFD(int fd,
const TouchFDCallback& callback) {
DCHECK_NE(fd, -1);
+ Error error;
struct timespec times[2];
- if (Error error = TimespecOrNowToStandardTimespec(atime.get(), &times[0])) {
+ if ((error = TimespecOrNowToStandardTimespec(atime.get(), &times[0]))
+ != ERROR_OK) {
viettrungluu 2015/09/22 22:04:58 You should also "git cl format" the change. The st
johngro 2015/09/22 22:24:12 Done.
callback.Run(error);
return;
}
- if (Error error = TimespecOrNowToStandardTimespec(mtime.get(), &times[1])) {
+ if ((error = TimespecOrNowToStandardTimespec(mtime.get(), &times[1]))
+ != ERROR_OK) {
callback.Run(error);
return;
}
« services/files/file_impl.cc ('K') | « services/files/file_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698