enum class fixups - testing non-zero

enum class fixups - testing non-zero

Fixups in preparation for changing the mojom C++ binding generator to
produce enum classes instead of just enums.  Specifically, address
issues where enums were being tested for truth by assuming that they
would be implicitly converted to ints and checked for non-zero-ness.

BUG=
R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/08f574e5254fa87c80ce0f35be3ab25fdfc5958c

[johngro, 2015-09-22 21:55:02]

johngro@google.com changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2015-09-22 22:04:58]

https://codereview.chromium.org/1355403002/diff/1/examples/echo_terminal/main.cc
File examples/echo_terminal/main.cc (right):

https://codereview.chromium.org/1355403002/diff/1/examples/echo_terminal/main...
examples/echo_terminal/main.cc:44: if (mojo::files::ERROR_OK != error) {
In general, I (and most humans) prefer to read "error != mojo::files::ERROR_OK".

https://codereview.chromium.org/1355403002/diff/1/services/files/directory_im...
File services/files/directory_impl.cc (right):

https://codereview.chromium.org/1355403002/diff/1/services/files/directory_im...
services/files/directory_impl.cc:194: if ((error = IsPathValid(path)) !=
ERROR_OK) {
I think I'd prefer if you just did:

Error error = IsPathValid(path);
if (error != ERROR_OK) {
...

(and similarly below, omitting "Error" where "error" has already been declared).

https://codereview.chromium.org/1355403002/diff/1/services/files/file_impl.cc
File services/files/file_impl.cc (right):

https://codereview.chromium.org/1355403002/diff/1/services/files/file_impl.cc...
services/files/file_impl.cc:75: if ((error = IsOffsetValid(offset)) != ERROR_OK)
{
Ditto.

https://codereview.chromium.org/1355403002/diff/1/services/files/shared_impl.cc
File services/files/shared_impl.cc (right):

https://codereview.chromium.org/1355403002/diff/1/services/files/shared_impl....
services/files/shared_impl.cc:65: != ERROR_OK) {
You should also "git cl format" the change. The standard formatting puts the !=
on the previous line.

[johngro, 2015-09-22 22:24:12]

https://codereview.chromium.org/1355403002/diff/1/examples/echo_terminal/main.cc
File examples/echo_terminal/main.cc (right):

https://codereview.chromium.org/1355403002/diff/1/examples/echo_terminal/main...
examples/echo_terminal/main.cc:44: if (mojo::files::ERROR_OK != error) {
On 2015/09/22 22:04:58, viettrungluu wrote:
> In general, I (and most humans) prefer to read "error !=
mojo::files::ERROR_OK".

Done.

https://codereview.chromium.org/1355403002/diff/1/services/files/directory_im...
File services/files/directory_impl.cc (right):

https://codereview.chromium.org/1355403002/diff/1/services/files/directory_im...
services/files/directory_impl.cc:194: if ((error = IsPathValid(path)) !=
ERROR_OK) {
On 2015/09/22 22:04:58, viettrungluu wrote:
> I think I'd prefer if you just did:
> 
> Error error = IsPathValid(path);
> if (error != ERROR_OK) {
> ...
> 
> (and similarly below, omitting "Error" where "error" has already been
declared).

Done.

https://codereview.chromium.org/1355403002/diff/1/services/files/file_impl.cc
File services/files/file_impl.cc (right):

https://codereview.chromium.org/1355403002/diff/1/services/files/file_impl.cc...
services/files/file_impl.cc:75: if ((error = IsOffsetValid(offset)) != ERROR_OK)
{
On 2015/09/22 22:04:58, viettrungluu wrote:
> Ditto.

Done.

https://codereview.chromium.org/1355403002/diff/1/services/files/shared_impl.cc
File services/files/shared_impl.cc (right):

https://codereview.chromium.org/1355403002/diff/1/services/files/shared_impl....
services/files/shared_impl.cc:65: != ERROR_OK) {
On 2015/09/22 22:04:58, viettrungluu wrote:
> You should also "git cl format" the change. The standard formatting puts the
!=
> on the previous line.

Done.

[viettrungluu, 2015-09-22 23:34:26]

lgtm

[johngro, 2015-09-22 23:58:06]

Committed patchset #2 (id:20001) manually as
08f574e5254fa87c80ce0f35be3ab25fdfc5958c (presubmit successful).