Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 13554003: Use NTP time for video frame timestamp. Add tracing for timestamps. (Closed)

Created:
7 years, 8 months ago by justinlin
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Use NTP time for video frame timestamp. Add tracing for capture timestamps. BUG=225209 TEST=Check that AppRTC still works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192670 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194268

Patch Set 1 : #

Total comments: 2

Patch Set 2 : nit #

Patch Set 3 : Fix RenderFrame using timestamp as nanoseconds. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M content/browser/renderer_host/media/web_contents_video_capture_device.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_capturer.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/rtc_video_capturer.cc View 1 2 3 chunks +22 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_renderer.cc View 1 2 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
justinlin
7 years, 8 months ago (2013-04-05 04:42:06 UTC) #1
holmer
lgtm
7 years, 8 months ago (2013-04-05 07:33:44 UTC) #2
no longer working on chromium
lgtm %nit https://codereview.chromium.org/13554003/diff/5001/content/renderer/media/rtc_video_capturer.cc File content/renderer/media/rtc_video_capturer.cc (right): https://codereview.chromium.org/13554003/diff/5001/content/renderer/media/rtc_video_capturer.cc#newcode19 content/renderer/media/rtc_video_capturer.cc:19: base::Time::Exploded exploded; nit, initialize the value to ...
7 years, 8 months ago (2013-04-05 08:56:34 UTC) #3
justinlin
thanks https://codereview.chromium.org/13554003/diff/5001/content/renderer/media/rtc_video_capturer.cc File content/renderer/media/rtc_video_capturer.cc (right): https://codereview.chromium.org/13554003/diff/5001/content/renderer/media/rtc_video_capturer.cc#newcode19 content/renderer/media/rtc_video_capturer.cc:19: base::Time::Exploded exploded; On 2013/04/05 08:56:34, xians1 wrote: > ...
7 years, 8 months ago (2013-04-05 19:03:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/13554003/11001
7 years, 8 months ago (2013-04-05 19:19:14 UTC) #5
commit-bot: I haz the power
Change committed as 192670
7 years, 8 months ago (2013-04-06 00:33:31 UTC) #6
justinlin
Fixed the issue that caused the test breakage: the webrtc_call.WebrtcCallTest.testLocalPreview test bypasses the normal path ...
7 years, 8 months ago (2013-04-15 06:33:51 UTC) #7
holmer
On 2013/04/15 06:33:51, justinlin wrote: > Fixed the issue that caused the test breakage: the ...
7 years, 8 months ago (2013-04-15 08:14:18 UTC) #8
justinlin
7 years, 8 months ago (2013-04-16 01:12:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r194268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698