Create GrDraw and start fast pathing src over rects

src/gpu/batches/GrAAFillRectBatch.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrAAFillRectBatch.h"
 
 #include "GrColor.h"
@@ skipping 295 matching lines @@
     geo.fViewMatrix = viewMatrix;
     geo.fLocalMatrix = localMatrix;
     geo.fRect = rect;
     geo.fDevRect = devRect;
 }
 
 namespace GrAAFillRectBatch {
 
 GrDrawBatch* Create(GrColor color,
                     const SkMatrix& viewMatrix,
                     const SkRect& rect,

[robertphillips, 2015/09/25 12:48:48]

We still need 'devRect' here ?

[joshualitt, 2015/09/25 18:17:12]

I can fix in a follow on

                     const SkRect& devRect) {
     AAFillRectBatchNoLocalMatrix* batch = AAFillRectBatchNoLocalMatrix::Create();
     append_to_batch(batch, color, viewMatrix, rect, devRect);
     batch->init();
     return batch;
 }
 
 GrDrawBatch* Create(GrColor color,
                     const SkMatrix& viewMatrix,
                     const SkMatrix& localMatrix,
-                    const SkRect& rect,
-                    const SkRect& devRect) {
+                    const SkRect& rect) {
+    //map rect
+    SkRect devRect;
+    viewMatrix.mapRect(&devRect, rect);
+
     AAFillRectBatchLocalMatrix* batch = AAFillRectBatchLocalMatrix::Create();
     append_to_batch(batch, color, viewMatrix, localMatrix, rect, devRect);
     batch->init();
     return batch;
 }
 
 void Append(GrBatch* origBatch,
             GrColor color,
             const SkMatrix& viewMatrix,
-            const SkRect& rect,
-            const SkRect& devRect) {
+            const SkRect& rect) {
+    // map rect
+    SkRect devRect;
+    viewMatrix.mapRect(&devRect, rect);
+
     AAFillRectBatchNoLocalMatrix* batch = origBatch->cast<AAFillRectBatchNoLocalMatrix>();
     append_to_batch(batch, color, viewMatrix, rect, devRect);
     batch->updateBoundsAfterAppend();
 }
 
 void Append(GrBatch* origBatch,
             GrColor color,
             const SkMatrix& viewMatrix,
             const SkMatrix& localMatrix,
             const SkRect& rect,

[robertphillips, 2015/09/25 12:48:48]

We still need 'devRect' here ?

[joshualitt, 2015/09/25 18:17:12]

I can fix in a follow on

             const SkRect& devRect) {
     AAFillRectBatchLocalMatrix* batch = origBatch->cast<AAFillRectBatchLocalMatrix>();
     append_to_batch(batch, color, viewMatrix, localMatrix, rect, devRect);
     batch->updateBoundsAfterAppend();
 }
 
 };
 
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
 #ifdef GR_TEST_UTILS
 
 #include "GrBatchTest.h"
 
 DRAW_BATCH_TEST_DEFINE(AAFillRectBatch) {
     GrColor color = GrRandomColor(random);
     SkMatrix viewMatrix = GrTest::TestMatrixInvertible(random);
     SkRect rect = GrTest::TestRect(random);
     SkRect devRect = GrTest::TestRect(random);
     return GrAAFillRectBatch::Create(color, viewMatrix, rect, devRect);
 }
 
 DRAW_BATCH_TEST_DEFINE(AAFillRectBatchLocalMatrix) {
     GrColor color = GrRandomColor(random);
     SkMatrix viewMatrix = GrTest::TestMatrixInvertible(random);
     SkMatrix localMatrix = GrTest::TestMatrix(random);
     SkRect rect = GrTest::TestRect(random);
-    SkRect devRect = GrTest::TestRect(random);
-    return GrAAFillRectBatch::Create(color, viewMatrix, localMatrix, rect, devRect);
+    return GrAAFillRectBatch::Create(color, viewMatrix, localMatrix, rect);
 }
 
 #endif