third_party/WebKit/Source/platform/graphics/ImageBuffer.h - Issue 1355333005: Implement Asynchronous image encoding for Canvas.toBlob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageBuffer.h

Issue 1355333005: Implement Asynchronous image encoding for Canvas.toBlob (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change async func to static so no need worry if canvas instance does not live long enough Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageBuffer.h

diff --git a/third_party/WebKit/Source/platform/graphics/ImageBuffer.h b/third_party/WebKit/Source/platform/graphics/ImageBuffer.h

index 8019b9547c0300777b40fc6eb93638bfc2648da1..7d73455e2fc3ce7dde70951906fea587e7e6f0d1 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageBuffer.h

+++ b/third_party/WebKit/Source/platform/graphics/ImageBuffer.h

@@ -154,8 +154,8 @@ private:

struct ImageDataBuffer {

ImageDataBuffer(const IntSize& size, const unsigned char* data) : m_data(data), m_size(size) { }

- String PLATFORM_EXPORT toDataURL(const String& mimeType, const double* quality) const;

- bool PLATFORM_EXPORT encodeImage(const String& mimeType, const double* quality, Vector<char>* output) const;

+ String PLATFORM_EXPORT toDataURL(const String& mimeType, const double& quality) const;

+ bool PLATFORM_EXPORT encodeImage(const String& mimeType, const double& quality, Vector<char>* output) const;

const unsigned char* pixels() const { return m_data; }

int height() const { return m_size.height(); }

int width() const { return m_size.width(); }