third_party/WebKit/Source/core/fileapi/File.h - Issue 1355333005: Implement Asynchronous image encoding for Canvas.toBlob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/File.h

Issue 1355333005: Implement Asynchronous image encoding for Canvas.toBlob (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change async func to static so no need worry if canvas instance does not live long enough Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-toBlob-toDataURL-race.js ('k') | third_party/WebKit/Source/core/fileapi/File.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/File.h

diff --git a/third_party/WebKit/Source/core/fileapi/File.h b/third_party/WebKit/Source/core/fileapi/File.h

index a620592fd0b823b8985ea1c820b4053a360ecef0..ed0b4dbc5da4c354ad5e94be2221378425892334 100644

--- a/third_party/WebKit/Source/core/fileapi/File.h

+++ b/third_party/WebKit/Source/core/fileapi/File.h

@@ -68,7 +68,7 @@ public:

return new File(name, modificationTime, blobDataHandle);

}

- static File* create(char* data, size_t bytes, const String& mimeType);

+ static File* create(const char* data, size_t bytes, const String& mimeType);

// For deserialization.

static File* createFromSerialization(const String& path, const String& name, const String& relativePath, UserVisibility userVisibility, bool hasSnaphotData, uint64_t size, double lastModified, PassRefPtr<BlobDataHandle> blobDataHandle)