Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 135533007: [Android WebView] Fix small licenses-related inconsistencies (Closed)

Created:
6 years, 10 months ago by mnaganov (inactive)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Fix small licenses-related inconsistencies 1) Add Apple PSL 2 (APSL 2) license into the whitelist. 2) Fix breakpad's "License" field to be "New BSD, Apple PSL 2.0 and Apache 2.0". Dropped "MIT/X derivate" because I've found no mentions of it in the project. 3) Fix webdriver's "License" field to be "Apache 2, MIT and GPL v2". The latter corresponds to old jQuery code, which was previously licensed under GPL v2, not GPL, as the field was stating. These changes make "breakpad" and "webdriver" projects to be recognized as "compatible" with the Android tree. R=frankf@chromium.org, mkosiba@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248928

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M android_webview/tools/webview_licenses.py View 1 chunk +1 line, -0 lines 0 comments Download
M breakpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/webdriver/README.chromium View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
mnaganov (inactive)
A tiny cleanup change, PTAL!
6 years, 10 months ago (2014-02-04 10:34:18 UTC) #1
mkosiba (inactive)
LGTM
6 years, 10 months ago (2014-02-04 10:41:14 UTC) #2
mnaganov (inactive)
Thanks, Marcin! frankf@, thestig@: Please confirm you agree with the change.
6 years, 10 months ago (2014-02-04 10:44:57 UTC) #3
frankf
lgtm but IANAL. I see the following only having GLP not GLPv2: third_party/webdriver/test_data/jquery-1.3.2.js
6 years, 10 months ago (2014-02-04 18:12:42 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/135533007/diff/1/third_party/webdriver/README.chromium File third_party/webdriver/README.chromium (right): https://codereview.chromium.org/135533007/diff/1/third_party/webdriver/README.chromium#newcode8 third_party/webdriver/README.chromium:8: License: Apache 2, MIT and GPL v2 This ...
6 years, 10 months ago (2014-02-04 19:46:04 UTC) #5
mnaganov (inactive)
On 2014/02/04 18:12:42, frankf wrote: > lgtm but IANAL. I see the following only having ...
6 years, 10 months ago (2014-02-04 21:45:31 UTC) #6
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 10 months ago (2014-02-04 21:46:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/135533007/1
6 years, 10 months ago (2014-02-04 22:33:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/135533007/1
6 years, 10 months ago (2014-02-05 01:14:43 UTC) #9
mnaganov (inactive)
6 years, 10 months ago (2014-02-05 08:48:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r248928 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698