Issue 135533006: Round app icon corners for bookmark apps in the launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135533006: Round app icon corners for bookmark apps in the launcher. (Closed)

Created:
6 years, 10 months ago by calamity

Modified:
6 years, 10 months ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@reattempt_icon_generation

Visibility:
Public.

More Reviews

Description

Round app icon corners for bookmark apps in the launcher. Bookmark apps can currently get square icons. This CL rounds the icons when displaying them in the app launcher. BUG=315632 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247580

Patch Set 1 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	chrome/browser/ui/app_list/extension_app_item.cc	View		2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/135533006/40001

6 years, 10 months ago (2014-01-28 18:19:37 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217348

6 years, 10 months ago (2014-01-28 20:45:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/135533006/40001

6 years, 10 months ago (2014-01-29 00:09:33 UTC) #5

Message was sent while issue was closed.

Change committed as 247580

Expand Messages | Collapse Messages