Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1355253002: [x64] Compare map instead of value to heap number map in ToStringStub. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Compare map instead of value to heap number map in ToStringStub. Fixes a typo introduced earlier, where we compare the value to heap number map instead of the map loaded previously. TBR=jarin@chromium.org Committed: https://crrev.com/02a2580b1636149d0c296591004e28bcd5fb4656 Cr-Commit-Position: refs/heads/master@{#30859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355253002/1
5 years, 3 months ago (2015-09-22 06:55:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 07:20:02 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 07:20:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02a2580b1636149d0c296591004e28bcd5fb4656
Cr-Commit-Position: refs/heads/master@{#30859}

Powered by Google App Engine
This is Rietveld 408576698