Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects-inl.h

Issue 13552002: ES6 symbols: fix corner cases of equality operators (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/runtime.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2486 matching lines...) Expand 10 before | Expand all | Expand 10 after
2497 void Name::set_hash_field(uint32_t value) { 2497 void Name::set_hash_field(uint32_t value) {
2498 WRITE_UINT32_FIELD(this, kHashFieldOffset, value); 2498 WRITE_UINT32_FIELD(this, kHashFieldOffset, value);
2499 #if V8_HOST_ARCH_64_BIT 2499 #if V8_HOST_ARCH_64_BIT
2500 WRITE_UINT32_FIELD(this, kHashFieldOffset + kIntSize, 0); 2500 WRITE_UINT32_FIELD(this, kHashFieldOffset + kIntSize, 0);
2501 #endif 2501 #endif
2502 } 2502 }
2503 2503
2504 2504
2505 bool Name::Equals(Name* other) { 2505 bool Name::Equals(Name* other) {
2506 if (other == this) return true; 2506 if (other == this) return true;
2507 if (this->IsUniqueName() && other->IsUniqueName()) return false; 2507 if (this->IsSymbol() || other->IsSymbol() ||
2508 (this->IsInternalizedString() && other->IsInternalizedString())) {
2509 return false;
2510 }
2508 return String::cast(this)->SlowEquals(String::cast(other)); 2511 return String::cast(this)->SlowEquals(String::cast(other));
2509 } 2512 }
2510 2513
2511 2514
2512 ACCESSORS(Symbol, name, Object, kNameOffset) 2515 ACCESSORS(Symbol, name, Object, kNameOffset)
2513 2516
2514 2517
2515 bool String::Equals(String* other) { 2518 bool String::Equals(String* other) {
2516 if (other == this) return true; 2519 if (other == this) return true;
2517 if (this->IsInternalizedString() && other->IsInternalizedString()) { 2520 if (this->IsInternalizedString() && other->IsInternalizedString()) {
(...skipping 3504 matching lines...) Expand 10 before | Expand all | Expand 10 after
6022 #undef WRITE_UINT32_FIELD 6025 #undef WRITE_UINT32_FIELD
6023 #undef READ_SHORT_FIELD 6026 #undef READ_SHORT_FIELD
6024 #undef WRITE_SHORT_FIELD 6027 #undef WRITE_SHORT_FIELD
6025 #undef READ_BYTE_FIELD 6028 #undef READ_BYTE_FIELD
6026 #undef WRITE_BYTE_FIELD 6029 #undef WRITE_BYTE_FIELD
6027 6030
6028 6031
6029 } } // namespace v8::internal 6032 } } // namespace v8::internal
6030 6033
6031 #endif // V8_OBJECTS_INL_H_ 6034 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698