ui/message_center/message_center_impl.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/message_center_impl.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/message_center/message_center_impl.cc

diff --git a/ui/message_center/message_center_impl.cc b/ui/message_center/message_center_impl.cc

index 1658d9870555b44dc942d4786bd59ca7e1c00788..6e745c9f25f49b02cc513251dd1b29d867aff895 100644

--- a/ui/message_center/message_center_impl.cc

+++ b/ui/message_center/message_center_impl.cc

@@ -340,7 +340,7 @@ PopupTimer::PopupTimer(const std::string& id,

: id_(id),

timeout_(timeout),

timer_controller_(controller),

- timer_(new base::OneShotTimer<PopupTimersController>) {}

+ timer_(new base::OneShotTimer) {}

PopupTimer::~PopupTimer() {

if (!timer_)

@@ -978,7 +978,7 @@ void MessageCenterImpl::EnterQuietModeWithExpire(

FOR_EACH_OBSERVER(

MessageCenterObserver, observer_list_, OnQuietModeChanged(true));

- quiet_mode_timer_.reset(new base::OneShotTimer<MessageCenterImpl>);

+ quiet_mode_timer_.reset(new base::OneShotTimer);

quiet_mode_timer_->Start(

FROM_HERE,

expires_in,

« chrome/browser/net/predictor_unittest.cc ('K') | « ui/message_center/message_center_impl.h ('k') | ui/message_center/views/message_popup_collection.h » ('j') | no next file with comments »