chrome/browser/spellchecker/feedback_sender.h - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/feedback_sender.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/predictor_unittest.cc ('K') | « chrome/browser/signin/cross_device_promo.h ('k') | chrome/browser/spellchecker/spellcheck_host_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/feedback_sender.h

diff --git a/chrome/browser/spellchecker/feedback_sender.h b/chrome/browser/spellchecker/feedback_sender.h

index 80b23ddea743bf4455e7117880a400721bb901c6..ec9755801a45ad357fca80ff362befa4a7891134 100644

--- a/chrome/browser/spellchecker/feedback_sender.h

+++ b/chrome/browser/spellchecker/feedback_sender.h

@@ -162,7 +162,7 @@ class FeedbackSender : public base::SupportsWeakPtr<FeedbackSender>,

// all of the renderers. The timer starts in StartFeedbackCollection() and

// stops in StopFeedbackCollection(). The timer stops and abandons its tasks

// on destruction.

- base::RepeatingTimer<FeedbackSender> timer_;

+ base::RepeatingTimer timer_;

// Feedback senders that need to stay alive for the duration of sending data.

// If a sender is destroyed before it finishes, then sending feedback will be