net/url_request/url_fetcher_core.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_fetcher_core.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_fetcher_core.cc

diff --git a/net/url_request/url_fetcher_core.cc b/net/url_request/url_fetcher_core.cc

index e07dcdfc7931b7a332d3d7a35eae08abf60f5169..1ecf9e5401e3471e9e1688c436433a9b7ad800f3 100644

--- a/net/url_request/url_fetcher_core.cc

+++ b/net/url_request/url_fetcher_core.cc

@@ -602,8 +602,7 @@ void URLFetcherCore::StartURLRequest() {

current_upload_bytes_ = -1;

// TODO(kinaba): http://crbug.com/118103. Implement upload callback in the

// layer and avoid using timer here.

- upload_progress_checker_timer_.reset(

- new base::RepeatingTimer<URLFetcherCore>());

+ upload_progress_checker_timer_.reset(new base::RepeatingTimer());

upload_progress_checker_timer_->Start(

FROM_HERE,

base::TimeDelta::FromMilliseconds(kUploadProgressTimerInterval),

« no previous file with comments | « net/url_request/url_fetcher_core.h ('k') | net/websockets/websocket_channel.h » ('j') | no next file with comments »