net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc

diff --git a/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc b/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc

index 59927dc2cb6d568ee911532beb93584d905bac01..a1a23821a6b4fe0c18d55bfc1e39b91329245a38 100644

--- a/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc

+++ b/net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc

@@ -112,8 +112,8 @@ class RealFetchTester {

scoped_ptr<DhcpProxyScriptFetcherWin> fetcher_;

bool finished_;

base::string16 pac_text_;

- base::OneShotTimer<RealFetchTester> timeout_;

- base::OneShotTimer<RealFetchTester> cancel_timer_;

+ base::OneShotTimer timeout_;

+ base::OneShotTimer cancel_timer_;

bool on_completion_is_error_;

};

@@ -260,7 +260,7 @@ class DummyDhcpProxyScriptAdapterFetcher

base::string16 pac_script_;

int fetch_delay_ms_;

CompletionCallback callback_;

- base::OneShotTimer<DummyDhcpProxyScriptAdapterFetcher> timer_;

+ base::OneShotTimer timer_;

};

class MockDhcpProxyScriptFetcherWin : public DhcpProxyScriptFetcherWin {

« no previous file with comments | « net/proxy/dhcp_proxy_script_fetcher_win.h ('k') | net/proxy/proxy_config_service_linux.cc » ('j') | no next file with comments »