content/browser/loader/detachable_resource_handler.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/detachable_resource_handler.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/detachable_resource_handler.h ('k') | content/browser/loader/power_save_block_resource_throttle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/detachable_resource_handler.cc

diff --git a/content/browser/loader/detachable_resource_handler.cc b/content/browser/loader/detachable_resource_handler.cc

index 139a6299d3f475c5b8196a55e3acc754823681b7..df9c357a888bb0658eb769b392f5d06b62d8fa19 100644

--- a/content/browser/loader/detachable_resource_handler.cc

+++ b/content/browser/loader/detachable_resource_handler.cc

@@ -63,7 +63,7 @@ void DetachableResourceHandler::Detach() {

next_handler_.reset();

// Time the request out if it takes too long.

- detached_timer_.reset(new base::OneShotTimer<DetachableResourceHandler>());

+ detached_timer_.reset(new base::OneShotTimer());

detached_timer_->Start(

FROM_HERE, cancel_delay_, this, &DetachableResourceHandler::Cancel);