components/sync_driver/model_association_manager.h - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/model_association_manager.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/gaia_cookie_manager_service.h ('k') | components/sync_driver/model_association_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/model_association_manager.h

diff --git a/components/sync_driver/model_association_manager.h b/components/sync_driver/model_association_manager.h

index 56d291fef7414f5a9b41b9bf1d4305007e944a44..b1491d8222f7c14210fada8b36d97f5cebb2404c 100644

--- a/components/sync_driver/model_association_manager.h

+++ b/components/sync_driver/model_association_manager.h

@@ -84,7 +84,7 @@ class ModelAssociationManager {

// and modify the timer.

// TODO(sync) : This would go away if we made this class be able to do

// Dependency injection. crbug.com/129212.

- base::OneShotTimer<ModelAssociationManager>* GetTimerForTesting();

+ base::OneShotTimer* GetTimerForTesting();

State state() const { return state_; }

@@ -149,7 +149,7 @@ class ModelAssociationManager {

ModelAssociationManagerDelegate* delegate_;

// Timer to track and limit how long a datatype takes to model associate.

- base::OneShotTimer<ModelAssociationManager> timer_;

+ base::OneShotTimer timer_;

DataTypeManager::ConfigureStatus configure_status_;