components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/search_provider.h ('k') | components/password_manager/core/browser/affiliated_match_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index d875557f9827aba6a3d6c473d54f23a0eacdd955..9419648a14454865a80cb640e822caf8b7f76903 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -115,8 +115,7 @@ PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {

}

scoped_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {

- return scoped_ptr<base::Timer>(

- new base::OneShotTimer<PageTimingMetricsSender>());

+ return make_scoped_ptr(new base::OneShotTimer);

}

} // namespace page_load_metrics

« no previous file with comments | « components/omnibox/browser/search_provider.h ('k') | components/password_manager/core/browser/affiliated_match_helper.h » ('j') | no next file with comments »