components/feedback/feedback_uploader.h - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/feedback_uploader.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_experiments_stats.h ('k') | components/history/core/browser/top_sites_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feedback/feedback_uploader.h

diff --git a/components/feedback/feedback_uploader.h b/components/feedback/feedback_uploader.h

index 9eebbd50d20ce6c4539eaa1df6c23655b8dea17c..814376e798fb17dbdc48028c590cbbfa143db710 100644

--- a/components/feedback/feedback_uploader.h

+++ b/components/feedback/feedback_uploader.h

@@ -67,7 +67,7 @@ class FeedbackUploader : public base::SupportsWeakPtr<FeedbackUploader> {

base::FilePath report_path_;

// Timer to upload the next report at.

- base::OneShotTimer<FeedbackUploader> upload_timer_;

+ base::OneShotTimer upload_timer_;

// Priority queue of reports prioritized by the time the report is supposed

// to be uploaded at.

std::priority_queue<scoped_refptr<FeedbackReport>,