chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/child_accounts/child_account_service.h ('k') | chrome/browser/sync/glue/sync_backend_host_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc

diff --git a/chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc b/chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc

index 1b165ea8337ba12f64283a4d0058f4048c4ef190..9d6891ca63e4fd2e0c54978663c191d0602777d6 100644

--- a/chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc

+++ b/chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc

@@ -18,7 +18,6 @@

#include "content/public/test/test_browser_thread_bundle.h"

#include "testing/gtest/include/gtest/gtest.h"

-using base::OneShotTimer;

using base::Thread;

using base::TimeDelta;

using content::BrowserThread;

@@ -37,7 +36,7 @@ class SyncBrowserThreadModelWorkerTest : public testing::Test {

bool did_do_work() { return did_do_work_; }

BrowserThreadModelWorker* worker() { return worker_.get(); }

- OneShotTimer<SyncBrowserThreadModelWorkerTest>* timer() { return &timer_; }

+ base::OneShotTimer* timer() { return &timer_; }

base::WeakPtrFactory<SyncBrowserThreadModelWorkerTest>* factory() {

return &weak_factory_;

}

@@ -89,7 +88,7 @@ class SyncBrowserThreadModelWorkerTest : public testing::Test {

private:

bool did_do_work_;

scoped_refptr<BrowserThreadModelWorker> worker_;

- OneShotTimer<SyncBrowserThreadModelWorkerTest> timer_;

+ base::OneShotTimer timer_;

content::TestBrowserThreadBundle thread_bundle_;