chrome/browser/safe_browsing/protocol_manager.h - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_manager.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h ('k') | chrome/browser/safe_browsing/safe_browsing_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/protocol_manager.h

diff --git a/chrome/browser/safe_browsing/protocol_manager.h b/chrome/browser/safe_browsing/protocol_manager.h

index 9e3907a8bc01168caba8c9264f5fb1f744ecd5a8..29af32608197a86abde17eb74353962d9d5989a0 100644

--- a/chrome/browser/safe_browsing/protocol_manager.h

+++ b/chrome/browser/safe_browsing/protocol_manager.h

@@ -321,11 +321,11 @@ class SafeBrowsingProtocolManager : public net::URLFetcherDelegate,

// For managing the next earliest time to query the SafeBrowsing servers for

// updates.

base::TimeDelta next_update_interval_;

- base::OneShotTimer<SafeBrowsingProtocolManager> update_timer_;

+ base::OneShotTimer update_timer_;

// timeout_timer_ is used to interrupt update requests which are taking

// too long.

- base::OneShotTimer<SafeBrowsingProtocolManager> timeout_timer_;

+ base::OneShotTimer timeout_timer_;

// All chunk requests that need to be made.

std::deque<ChunkUrl> chunk_request_urls_;