chrome/browser/printing/print_view_manager_base.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager_base.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/printing/print_view_manager_base.cc

diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc

index 8ca2486dc6e584d2e915b4f28eca122256cea6fc..6515b035cee0444236e5150336dad67f22dcd763 100644

--- a/chrome/browser/printing/print_view_manager_base.cc

+++ b/chrome/browser/printing/print_view_manager_base.cc

@@ -450,7 +450,7 @@ bool PrintViewManagerBase::RunInnerMessageLoop() {

// be CPU bound, the page overly complex/large or the system just

// memory-bound.

static const int kPrinterSettingsTimeout = 60000;

- base::OneShotTimer<base::MessageLoop> quit_timer;

+ base::OneShotTimer quit_timer;

quit_timer.Start(FROM_HERE,

TimeDelta::FromMilliseconds(kPrinterSettingsTimeout),

base::MessageLoop::current(), &base::MessageLoop::Quit);

« no previous file with comments | « chrome/browser/prerender/prerender_manager.h ('k') | chrome/browser/process_singleton_posix.cc » ('j') | no next file with comments »