chrome/browser/notifications/extension_welcome_notification.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification.h ('k') | chrome/browser/notifications/screen_lock_notification_blocker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification.cc

diff --git a/chrome/browser/notifications/extension_welcome_notification.cc b/chrome/browser/notifications/extension_welcome_notification.cc

index 383107fe18b1cced99e481215b26fefc14ffa312..b34bf3dfba63d1fbad50e081b8f203b65cebac63 100644

--- a/chrome/browser/notifications/extension_welcome_notification.cc

+++ b/chrome/browser/notifications/extension_welcome_notification.cc

@@ -308,8 +308,7 @@ void ExtensionWelcomeNotification::StartExpirationTimer() {

expiration_timestamp = GetExpirationTimestamp();

DCHECK(!expiration_timestamp.is_null());

}

- expiration_timer_.reset(

- new base::OneShotTimer<ExtensionWelcomeNotification>());

+ expiration_timer_.reset(new base::OneShotTimer());

expiration_timer_->Start(

FROM_HERE,

expiration_timestamp - delegate_->GetCurrentTime(),