chrome/browser/extensions/api/audio_modem/audio_modem_api.h - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/audio_modem/audio_modem_api.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_database.h ('k') | chrome/browser/extensions/api/audio_modem/audio_modem_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/audio_modem/audio_modem_api.h

diff --git a/chrome/browser/extensions/api/audio_modem/audio_modem_api.h b/chrome/browser/extensions/api/audio_modem/audio_modem_api.h

index dcccbfeff43b9985e02c8b7faecd3853e5dfdd9b..77034b5ee3a64ee9349ae147868b43554f47b565 100644

--- a/chrome/browser/extensions/api/audio_modem/audio_modem_api.h

+++ b/chrome/browser/extensions/api/audio_modem/audio_modem_api.h

@@ -73,11 +73,11 @@ class AudioModemAPI final : public BrowserContextKeyedAPI {

std::string transmitters_[2];

// Timeouts for the currently active transmits, indexed by AudioType.

- base::OneShotTimer<AudioModemAPI> transmit_timers_[2];

+ base::OneShotTimer transmit_timers_[2];

// Maps of currently receiving app ID => timeouts. Indexed by AudioType.

// We own all of these pointers. Do not remove them without calling delete.

- std::map<std::string, base::OneShotTimer<AudioModemAPI>*> receive_timers_[2];

+ std::map<std::string, base::OneShotTimer*> receive_timers_[2];

// BrowserContextKeyedAPI implementation.

static const bool kServiceIsCreatedWithBrowserContext = false;