chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screens/user_selection_screen.h ('k') | chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h

diff --git a/chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h b/chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h

index 5d1c0c25020fa890f8f04c23c00a0c344aa9a7b2..b8cdd8b5dad10130827e256f3b21db653417181f 100644

--- a/chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h

+++ b/chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.h

@@ -50,7 +50,7 @@ class ScreenshotTestingMixin : public MixinBasedBrowserTest::Mixin {

// Required for current implementation of

// SynchronizeAnimationLoadWithCompositor()

- base::OneShotTimer<ScreenshotTestingMixin> timer_;

+ base::OneShotTimer timer_;

base::Closure animation_waiter_quitter_;

// Is true if testing with screenshots is turned on with all proper switches.