chrome/browser/android/feedback/connectivity_checker.cc - Issue 1355063004: Template methods on Timer classes instead of the classes themselves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/feedback/connectivity_checker.cc

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timer: fixcaller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/trace_event_system_stats_monitor.h ('k') | chrome/browser/android/omnibox/autocomplete_controller_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/feedback/connectivity_checker.cc

diff --git a/chrome/browser/android/feedback/connectivity_checker.cc b/chrome/browser/android/feedback/connectivity_checker.cc

index 11d1037999521c1d5976c51fc39ddb7e073874a1..5e70d3477f318e05a912efa45b73410d54112e79 100644

--- a/chrome/browser/android/feedback/connectivity_checker.cc

+++ b/chrome/browser/android/feedback/connectivity_checker.cc

@@ -100,7 +100,7 @@ class ConnectivityChecker : public net::URLFetcherDelegate {

// has already happened, and no further action should be taken.

bool is_being_destroyed_;

- scoped_ptr<base::OneShotTimer<ConnectivityChecker>> expiration_timer_;

+ scoped_ptr<base::OneShotTimer> expiration_timer_;

};

void ConnectivityChecker::OnURLFetchComplete(const net::URLFetcher* source) {

@@ -147,7 +147,7 @@ void ConnectivityChecker::StartAsyncCheck() {

net::LOAD_DO_NOT_SEND_COOKIES |

net::LOAD_DO_NOT_SEND_AUTH_DATA);

url_fetcher_->Start();

- expiration_timer_.reset(new base::OneShotTimer<ConnectivityChecker>());

+ expiration_timer_.reset(new base::OneShotTimer());

expiration_timer_->Start(FROM_HERE, timeout_, this,

&ConnectivityChecker::OnTimeout);

}