Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/browser/jumplist_win.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: timer: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_JUMPLIST_WIN_H_ 5 #ifndef CHROME_BROWSER_JUMPLIST_WIN_H_
6 #define CHROME_BROWSER_JUMPLIST_WIN_H_ 6 #define CHROME_BROWSER_JUMPLIST_WIN_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 162
163 // Items in the "Most Visited" category of the application JumpList, 163 // Items in the "Most Visited" category of the application JumpList,
164 // protected by the list_lock_. 164 // protected by the list_lock_.
165 ShellLinkItemList most_visited_pages_; 165 ShellLinkItemList most_visited_pages_;
166 166
167 // Items in the "Recently Closed" category of the application JumpList, 167 // Items in the "Recently Closed" category of the application JumpList,
168 // protected by the list_lock_. 168 // protected by the list_lock_.
169 ShellLinkItemList recently_closed_pages_; 169 ShellLinkItemList recently_closed_pages_;
170 170
171 // Timer for requesting delayed updates of the jumplist. 171 // Timer for requesting delayed updates of the jumplist.
172 base::OneShotTimer<JumpList> timer_; 172 base::OneShotTimer timer_;
173 173
174 // A list of URLs we need to retrieve their favicons, 174 // A list of URLs we need to retrieve their favicons,
175 // protected by the list_lock_. 175 // protected by the list_lock_.
176 typedef std::pair<std::string, scoped_refptr<ShellLinkItem> > URLPair; 176 typedef std::pair<std::string, scoped_refptr<ShellLinkItem> > URLPair;
177 std::list<URLPair> icon_urls_; 177 std::list<URLPair> icon_urls_;
178 178
179 // Id of last favicon task. It's used to cancel current task if a new one 179 // Id of last favicon task. It's used to cancel current task if a new one
180 // comes in before it finishes. 180 // comes in before it finishes.
181 base::CancelableTaskTracker::TaskId task_id_; 181 base::CancelableTaskTracker::TaskId task_id_;
182 182
183 // Lock for most_visited_pages_, recently_closed_pages_, icon_urls_ 183 // Lock for most_visited_pages_, recently_closed_pages_, icon_urls_
184 // as they may be used by up to 3 threads. 184 // as they may be used by up to 3 threads.
185 base::Lock list_lock_; 185 base::Lock list_lock_;
186 186
187 // For callbacks may be run after destruction. 187 // For callbacks may be run after destruction.
188 base::WeakPtrFactory<JumpList> weak_ptr_factory_; 188 base::WeakPtrFactory<JumpList> weak_ptr_factory_;
189 189
190 DISALLOW_COPY_AND_ASSIGN(JumpList); 190 DISALLOW_COPY_AND_ASSIGN(JumpList);
191 }; 191 };
192 192
193 #endif // CHROME_BROWSER_JUMPLIST_WIN_H_ 193 #endif // CHROME_BROWSER_JUMPLIST_WIN_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698