Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/spellchecker/feedback_sender.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: timer: fixcaller Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // An object to record and send user feedback to spelling service. The spelling 5 // An object to record and send user feedback to spelling service. The spelling
6 // service uses the feedback to improve its suggestions. 6 // service uses the feedback to improve its suggestions.
7 // 7 //
8 // Assigns uint32 hash identifiers to spelling suggestions from spelling service 8 // Assigns uint32 hash identifiers to spelling suggestions from spelling service
9 // and stores these suggestions. Records user's actions on these suggestions. 9 // and stores these suggestions. Records user's actions on these suggestions.
10 // Periodically sends batches of user feedback to the spelling service. 10 // Periodically sends batches of user feedback to the spelling service.
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 // When the session started. 155 // When the session started.
156 base::Time session_start_; 156 base::Time session_start_;
157 157
158 // The URL where the feedback data should be sent. 158 // The URL where the feedback data should be sent.
159 GURL feedback_service_url_; 159 GURL feedback_service_url_;
160 160
161 // A timer to periodically request a list of document spelling markers from 161 // A timer to periodically request a list of document spelling markers from
162 // all of the renderers. The timer starts in StartFeedbackCollection() and 162 // all of the renderers. The timer starts in StartFeedbackCollection() and
163 // stops in StopFeedbackCollection(). The timer stops and abandons its tasks 163 // stops in StopFeedbackCollection(). The timer stops and abandons its tasks
164 // on destruction. 164 // on destruction.
165 base::RepeatingTimer<FeedbackSender> timer_; 165 base::RepeatingTimer timer_;
166 166
167 // Feedback senders that need to stay alive for the duration of sending data. 167 // Feedback senders that need to stay alive for the duration of sending data.
168 // If a sender is destroyed before it finishes, then sending feedback will be 168 // If a sender is destroyed before it finishes, then sending feedback will be
169 // canceled. 169 // canceled.
170 ScopedVector<net::URLFetcher> senders_; 170 ScopedVector<net::URLFetcher> senders_;
171 171
172 DISALLOW_COPY_AND_ASSIGN(FeedbackSender); 172 DISALLOW_COPY_AND_ASSIGN(FeedbackSender);
173 }; 173 };
174 174
175 } // namespace spellcheck 175 } // namespace spellcheck
176 176
177 #endif // CHROME_BROWSER_SPELLCHECKER_FEEDBACK_SENDER_H_ 177 #endif // CHROME_BROWSER_SPELLCHECKER_FEEDBACK_SENDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/signin/cross_device_promo.h ('k') | chrome/browser/spellchecker/spellcheck_host_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698