Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: chrome/browser/jumplist_win.h

Issue 1355063004: Template methods on Timer classes instead of the classes themselves. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: timer: fixcaller Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_JUMPLIST_WIN_H_ 5 #ifndef CHROME_BROWSER_JUMPLIST_WIN_H_
6 #define CHROME_BROWSER_JUMPLIST_WIN_H_ 6 #define CHROME_BROWSER_JUMPLIST_WIN_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 163
164 // Items in the "Most Visited" category of the application JumpList, 164 // Items in the "Most Visited" category of the application JumpList,
165 // protected by the list_lock_. 165 // protected by the list_lock_.
166 ShellLinkItemList most_visited_pages_; 166 ShellLinkItemList most_visited_pages_;
167 167
168 // Items in the "Recently Closed" category of the application JumpList, 168 // Items in the "Recently Closed" category of the application JumpList,
169 // protected by the list_lock_. 169 // protected by the list_lock_.
170 ShellLinkItemList recently_closed_pages_; 170 ShellLinkItemList recently_closed_pages_;
171 171
172 // Timer for requesting delayed updates of the jumplist. 172 // Timer for requesting delayed updates of the jumplist.
173 base::OneShotTimer<JumpList> timer_; 173 base::OneShotTimer timer_;
174 174
175 // A list of URLs we need to retrieve their favicons, 175 // A list of URLs we need to retrieve their favicons,
176 // protected by the list_lock_. 176 // protected by the list_lock_.
177 typedef std::pair<std::string, scoped_refptr<ShellLinkItem> > URLPair; 177 typedef std::pair<std::string, scoped_refptr<ShellLinkItem> > URLPair;
178 std::list<URLPair> icon_urls_; 178 std::list<URLPair> icon_urls_;
179 179
180 // Id of last favicon task. It's used to cancel current task if a new one 180 // Id of last favicon task. It's used to cancel current task if a new one
181 // comes in before it finishes. 181 // comes in before it finishes.
182 base::CancelableTaskTracker::TaskId task_id_; 182 base::CancelableTaskTracker::TaskId task_id_;
183 183
184 // Lock for most_visited_pages_, recently_closed_pages_, icon_urls_ 184 // Lock for most_visited_pages_, recently_closed_pages_, icon_urls_
185 // as they may be used by up to 3 threads. 185 // as they may be used by up to 3 threads.
186 base::Lock list_lock_; 186 base::Lock list_lock_;
187 187
188 // For callbacks may be run after destruction. 188 // For callbacks may be run after destruction.
189 base::WeakPtrFactory<JumpList> weak_ptr_factory_; 189 base::WeakPtrFactory<JumpList> weak_ptr_factory_;
190 190
191 DISALLOW_COPY_AND_ASSIGN(JumpList); 191 DISALLOW_COPY_AND_ASSIGN(JumpList);
192 }; 192 };
193 193
194 #endif // CHROME_BROWSER_JUMPLIST_WIN_H_ 194 #endif // CHROME_BROWSER_JUMPLIST_WIN_H_
OLDNEW
« no previous file with comments | « chrome/browser/image_decoder.cc ('k') | chrome/browser/media/android/remote/remote_media_player_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698