Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1355063002: try stosd/w (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

try stosd/w While we're trying things and reverting them, might as well try this too. BUG=skia:4316 Blinking in and out for perf.skia.org. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/3ca0f626a07e9b534d14a2d8213eedb93c5f7534

Patch Set 1 #

Patch Set 2 : maybe? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M include/core/SkUtils.h View 1 3 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mtklein
lgtm
5 years, 3 months ago (2015-09-21 00:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355063002/1
5 years, 3 months ago (2015-09-21 00:44:50 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/3346)
5 years, 3 months ago (2015-09-21 00:45:33 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355063002/20001
5 years, 3 months ago (2015-09-21 00:59:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 01:03:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355063002/20001
5 years, 3 months ago (2015-09-21 01:04:58 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/3ca0f626a07e9b534d14a2d8213eedb93c5f7534
5 years, 3 months ago (2015-09-21 01:05:27 UTC) #14
mtklein
5 years, 3 months ago (2015-09-21 01:05:55 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1356983004/ by mtklein@google.com.

The reason for reverting is: boink.

Powered by Google App Engine
This is Rietveld 408576698