Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1354973003: crashpad: set up for wow64 testing (Closed)

Created:
5 years, 3 months ago by scottmg
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

crashpad: set up for wow64 testing Rename bots to be more clear. Make the x64 bots build both bitnesses so upcoming code can do wow64 testing. e.g. https://codereview.chromium.org/1349313003. R=dpranke@chromium.org BUG=crashpad:50 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296792

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove unnecessary |slavebuilddir|s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -652 lines) Patch
M masters/master.client.crashpad/builders.pyl View 1 6 chunks +2 lines, -8 lines 0 comments Download
M scripts/slave/recipes/crashpad/continuous.py View 2 chunks +27 lines, -4 lines 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_dbg.json View 1 chunk +0 lines, -69 lines 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_dbg_clobber.json View 1 chunk +0 lines, -88 lines 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_rel.json View 1 chunk +0 lines, -69 lines 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_rel_clobber.json View 1 chunk +0 lines, -88 lines 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg.json View 1 chunk +10 lines, -1 line 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_dbg_clobber.json View 1 chunk +10 lines, -1 line 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel.json View 1 chunk +10 lines, -1 line 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x64_rel_clobber.json View 1 chunk +10 lines, -1 line 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg.json View 1 chunk +0 lines, -72 lines 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_dbg_clobber.json View 1 chunk +0 lines, -91 lines 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel.json View 1 chunk +0 lines, -72 lines 0 comments Download
D scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_rel_clobber.json View 1 chunk +0 lines, -91 lines 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_dbg_clobber.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/recipes/crashpad/continuous.expected/crashpad_win_x86_wow64_rel_clobber.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scottmg
5 years, 3 months ago (2015-09-18 23:05:14 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/1354973003/diff/1/masters/master.client.crashpad/builders.pyl File masters/master.client.crashpad/builders.pyl (right): https://codereview.chromium.org/1354973003/diff/1/masters/master.client.crashpad/builders.pyl#newcode62 masters/master.client.crashpad/builders.pyl:62: "slavebuilddir": "chromium_win_x86_wow64_dbg", slavebuilddir defaults to the builder name, ...
5 years, 3 months ago (2015-09-20 20:57:01 UTC) #2
scottmg
https://codereview.chromium.org/1354973003/diff/1/masters/master.client.crashpad/builders.pyl File masters/master.client.crashpad/builders.pyl (right): https://codereview.chromium.org/1354973003/diff/1/masters/master.client.crashpad/builders.pyl#newcode62 masters/master.client.crashpad/builders.pyl:62: "slavebuilddir": "chromium_win_x86_wow64_dbg", On 2015/09/20 20:57:00, Dirk Pranke wrote: > ...
5 years, 3 months ago (2015-09-21 18:26:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354973003/20001
5 years, 3 months ago (2015-09-21 18:26:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296792
5 years, 3 months ago (2015-09-21 18:32:51 UTC) #7
scottmg
5 years, 3 months ago (2015-09-22 06:02:56 UTC) #8
Message was sent while issue was closed. 
On 2015/09/21 18:32:51, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=296792

Darn, I renamed the x64 bots in continuous.py, but not in builders.pyl. Will
send a fix.

Powered by Google App Engine
This is Rietveld 408576698