Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 135493004: android envsetup: Stop honoring CHROME_ANDROID_WEBVIEW_ENABLE_DMPROF. (Closed)

Created:
6 years, 10 months ago by Nico
Modified:
6 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, mnaganov (inactive), Primiano Tucci (use gerrit)
Visibility:
Public.

Description

android envsetup: Stop honoring CHROME_ANDROID_WEBVIEW_ENABLE_DMPROF. Nothing sets this env var. (I checked with the folks who added this line, who confirmed that this is unused.) If something like this gets added again in the future, it shouldn't use a global env var to turn it on but a single gyp define (that's hopefully identical for desktop and mobile). BUG=330631 R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/android/envsetup_functions.sh View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
6 years, 10 months ago (2014-02-03 19:32:57 UTC) #1
Torne
lgtm
6 years, 10 months ago (2014-02-04 10:35:12 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 10 months ago (2014-02-04 14:20:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/135493004/1
6 years, 10 months ago (2014-02-04 14:21:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 15:13:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223185
6 years, 10 months ago (2014-02-04 15:13:01 UTC) #6
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 15:13:05 UTC) #7
Nico
6 years, 10 months ago (2014-02-04 15:23:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r248722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698