Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135493002: Plumb debug name via debug info (Closed)

Created:
6 years, 11 months ago by Ian Vollick
Modified:
6 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Plumb debug name via debug info There used to be a separate channel for plumbing back a layer's debug name. The debug info object is more general, and we can just send the debug name through it. This patch depends on https://codereview.chromium.org/135473002/ R=jamesr@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -54 lines) Patch
M cc/layers/heads_up_display_layer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/heads_up_display_layer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/layers/layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer.cc View 2 chunks +1 line, -9 lines 0 comments Download
M cc/layers/layer_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/layer_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/layers/layer_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/layers/render_surface_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +12 lines, -5 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/renderer/compositor_bindings/web_layer_impl.cc View 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ian Vollick
6 years, 11 months ago (2014-01-11 14:30:02 UTC) #1
jamesr
lgtm
6 years, 11 months ago (2014-01-13 18:32:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/135493002/1
6 years, 11 months ago (2014-01-13 21:45:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/135493002/1
6 years, 11 months ago (2014-01-14 00:40:22 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=115346
6 years, 11 months ago (2014-01-14 06:16:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/135493002/1
6 years, 11 months ago (2014-01-14 17:32:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/135493002/1
6 years, 11 months ago (2014-01-14 23:22:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/135493002/1
6 years, 11 months ago (2014-01-15 02:47:34 UTC) #8
Ian Vollick
6 years, 11 months ago (2014-01-15 18:52:44 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 manually as r244948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698