Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Unified Diff: Source/platform/graphics/filters/FEDiffuseLighting.cpp

Issue 1354923003: Remove kernelUnitLength plumbing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: More TEs Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/filters/FEDiffuseLighting.h ('k') | Source/platform/graphics/filters/FELighting.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/filters/FEDiffuseLighting.cpp
diff --git a/Source/platform/graphics/filters/FEDiffuseLighting.cpp b/Source/platform/graphics/filters/FEDiffuseLighting.cpp
index ba154b97f0f5091902d01f758c160e8821ad2b91..8429690d30c00b067a8c52b3ee338be850ae444f 100644
--- a/Source/platform/graphics/filters/FEDiffuseLighting.cpp
+++ b/Source/platform/graphics/filters/FEDiffuseLighting.cpp
@@ -29,16 +29,15 @@
namespace blink {
FEDiffuseLighting::FEDiffuseLighting(Filter* filter, const Color& lightingColor, float surfaceScale,
- float diffuseConstant, float kernelUnitLengthX, float kernelUnitLengthY, PassRefPtr<LightSource> lightSource)
- : FELighting(filter, DiffuseLighting, lightingColor, surfaceScale, diffuseConstant, 0, 0, kernelUnitLengthX, kernelUnitLengthY, lightSource)
+ float diffuseConstant, PassRefPtr<LightSource> lightSource)
+ : FELighting(filter, DiffuseLighting, lightingColor, surfaceScale, diffuseConstant, 0, 0, lightSource)
{
}
PassRefPtrWillBeRawPtr<FEDiffuseLighting> FEDiffuseLighting::create(Filter* filter, const Color& lightingColor,
- float surfaceScale, float diffuseConstant, float kernelUnitLengthX,
- float kernelUnitLengthY, PassRefPtr<LightSource> lightSource)
+ float surfaceScale, float diffuseConstant, PassRefPtr<LightSource> lightSource)
{
- return adoptRefWillBeNoop(new FEDiffuseLighting(filter, lightingColor, surfaceScale, diffuseConstant, kernelUnitLengthX, kernelUnitLengthY, lightSource));
+ return adoptRefWillBeNoop(new FEDiffuseLighting(filter, lightingColor, surfaceScale, diffuseConstant, lightSource));
}
FEDiffuseLighting::~FEDiffuseLighting()
@@ -85,32 +84,6 @@ bool FEDiffuseLighting::setDiffuseConstant(float diffuseConstant)
return true;
}
-float FEDiffuseLighting::kernelUnitLengthX() const
-{
- return m_kernelUnitLengthX;
-}
-
-bool FEDiffuseLighting::setKernelUnitLengthX(float kernelUnitLengthX)
-{
- if (m_kernelUnitLengthX == kernelUnitLengthX)
- return false;
- m_kernelUnitLengthX = kernelUnitLengthX;
- return true;
-}
-
-float FEDiffuseLighting::kernelUnitLengthY() const
-{
- return m_kernelUnitLengthY;
-}
-
-bool FEDiffuseLighting::setKernelUnitLengthY(float kernelUnitLengthY)
-{
- if (m_kernelUnitLengthY == kernelUnitLengthY)
- return false;
- m_kernelUnitLengthY = kernelUnitLengthY;
- return true;
-}
-
const LightSource* FEDiffuseLighting::lightSource() const
{
return m_lightSource.get();
@@ -126,9 +99,7 @@ TextStream& FEDiffuseLighting::externalRepresentation(TextStream& ts, int indent
writeIndent(ts, indent);
ts << "[feDiffuseLighting";
FilterEffect::externalRepresentation(ts);
- ts << " surfaceScale=\"" << m_surfaceScale << "\" "
- << "diffuseConstant=\"" << m_diffuseConstant << "\" "
- << "kernelUnitLength=\"" << m_kernelUnitLengthX << ", " << m_kernelUnitLengthY << "\"]\n";
+ ts << " surfaceScale=\"" << m_surfaceScale << "\" " << "diffuseConstant=\"" << m_diffuseConstant << "\"]\n";
inputEffect(0)->externalRepresentation(ts, indent + 1);
return ts;
}
« no previous file with comments | « Source/platform/graphics/filters/FEDiffuseLighting.h ('k') | Source/platform/graphics/filters/FELighting.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698