Componentize chrome/browser/sync/backup_rollback_controller

Componentize chrome/browser/sync/backup_rollback_controller

. Moved backup_rollback_controller.[cc/h] and its unittest to components/sync_driver
. Added backup_rollback_controller_unittest into .gn build.
. Formatted backup_rollback_controller files using cl format.
. Added backup_rollback_controller* under sync_driver namespace.

BUG=511242
Committed: https://crrev.com/4316e6a96c8cdb263a8e95a8091dcf1b3a82dd89
Cr-Commit-Position: refs/heads/master@{#349906}

[Abhishek, 2015-09-18 12:51:43]

abhishek.a21@samsung.com changed reviewers:
+ droger@chromium.org

[Abhishek, 2015-09-18 12:51:43]

PTAL!

[droger, 2015-09-18 13:04:14]

droger@chromium.org changed reviewers:
+ zea@chromium.org

[droger, 2015-09-18 13:04:14]

LGTM once the namespace is fixed.

+zea as OWNER.

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
File components/sync_driver/backup_rollback_controller.cc (right):

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.cc:16: namespace browser_sync
{
namespace sync_driver {

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.cc:100: }  // namespace
browser_sync
}  // namespace sync_driver

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
File components/sync_driver/backup_rollback_controller.h (right):

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.h:17: namespace browser_sync {
Delete lines 15-17: everything in sync_driver namespace.

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.h:61: }  // namespace
browser_sync
}  // namespace sync_driver

[Abhishek, 2015-09-18 14:00:49]

PTAL #2!

I've resolved all the comments.

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
File components/sync_driver/backup_rollback_controller.cc (right):

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.cc:16: namespace browser_sync
{
On 2015/09/18 13:04:14, droger wrote:
> namespace sync_driver {

Done.

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.cc:100: }  // namespace
browser_sync
On 2015/09/18 13:04:14, droger wrote:
> }  // namespace sync_driver

Done.

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
File components/sync_driver/backup_rollback_controller.h (right):

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.h:17: namespace browser_sync {
On 2015/09/18 13:04:14, droger wrote:
> Delete lines 15-17: everything in sync_driver namespace.

Done.

https://codereview.chromium.org/1354883003/diff/1/components/sync_driver/back...
components/sync_driver/backup_rollback_controller.h:61: }  // namespace
browser_sync
On 2015/09/18 13:04:14, droger wrote:
> }  // namespace sync_driver

Done.

[droger, 2015-09-18 14:01:47]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-18 14:02:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354883003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354883003/20001

[commit-bot: I haz the power, 2015-09-18 15:04:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 15:04:36]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2015-09-18 20:44:29]

LGTM, thanks!

https://codereview.chromium.org/1354883003/diff/20001/components/sync_driver/...
File components/sync_driver/backup_rollback_controller.h (right):

https://codereview.chromium.org/1354883003/diff/20001/components/sync_driver/...
components/sync_driver/backup_rollback_controller.h:14: class SyncPrefs;
nit: newline above.

[Abhishek, 2015-09-21 05:36:19]

Updated patchset #3!

https://codereview.chromium.org/1354883003/diff/20001/components/sync_driver/...
File components/sync_driver/backup_rollback_controller.h (right):

https://codereview.chromium.org/1354883003/diff/20001/components/sync_driver/...
components/sync_driver/backup_rollback_controller.h:14: class SyncPrefs;
On 2015/09/18 20:44:28, Nicolas Zea wrote:
> nit: newline above.

Done.

[Abhishek, 2015-09-21 05:36:24]

The CQ bit was checked by abhishek.a21@samsung.com

[Abhishek, 2015-09-21 05:36:24]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1354883003/#ps40001
(title: "updated")

[commit-bot: I haz the power, 2015-09-21 05:36:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1354883003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1354883003/40001

[commit-bot: I haz the power, 2015-09-21 06:57:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-21 06:58:38]

Patchset 3 (id:??) landed as
https://crrev.com/4316e6a96c8cdb263a8e95a8091dcf1b3a82dd89
Cr-Commit-Position: refs/heads/master@{#349906}