chrome/browser/ui/cocoa/tabs/tab_view.mm - Issue 1354873002: Mac: Prevent mouse events reaching subviews while a window has an attached Sheet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_view.mm

Issue 1354873002: Mac: Prevent mouse events reaching subviews while a window has an attached Sheet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TabView menu check now obsolete Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/tabs/tab_view.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_view.mm b/chrome/browser/ui/cocoa/tabs/tab_view.mm

index ea826ff8b463931d0e02afe74c6a1c385d8b300a..098375aa9c626ba625b4b9f9df36b33c799fb65a 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_view.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_view.mm

@@ -200,11 +200,6 @@ CGFloat LineWidthFromContext(CGContextRef context) {

if ([self isClosing])

return nil;

- // Sheets, being window-modal, should block contextual menus. For some reason

- // they do not. Disallow them ourselves.

- if ([[self window] attachedSheet])

- return nil;

return [controller_ menu];

}

« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_view.mm ('k') | no next file » | no next file with comments »