MediaRecorder: Adding BlobEvent and connecting it in MediaRecorderHandler

LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html

Index: LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html
diff --git a/LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html b/LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html
index fff0eea42e9098dbf4a57ad462671af65050d25f..877c0ea908a45c77c761ba17c49d68ab4cb92ae9 100644
--- a/LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html
+++ b/LayoutTests/fast/mediarecorder/MediaRecorder-basic-video.html
@@ -4,21 +4,35 @@
 <script>
 
 var test = async_test('checks the video-only MediaRecorder API.');
+var recorder;
 
 recorderOnDataAvailable = test.step_func(function(event) {
-    assert_greater_than(event.data.size, 0, 'Recorded data size should be > 0');
-    assert_equals(recorder.state, "recording");
+    if (event) {
+      assert_greater_than(event.data.size, 0, 'Recorded data size should be > 0');
+      assert_equals(recorder.state, "recording");
+    } else {
+      assert_equals(recorder.state, "inactive");
+    }
 
     // TODO(mcasas): Let the test record for a while.
     // TODO(mcasas): Consider storing the recorded data and playing it back.
 
-    test.done();
+    recorder.onstop = recorderOnStopExpected;

[Peter Beverloo, 2015/09/18 13:07:26]

The recorderOnStopExpected function is never defined? Did you run this test or
are it theoretical changes?

[mcasas, 2015/09/21 15:24:15]

I didn't hit it in this test, but I surely did during the integration
phase, so I just thought it would be a good thing to catch that
here.

[Peter Beverloo, 2015/09/22 14:03:42]

Yes, but you don't define |recorderOnStopExpected| anywhere - it's an undefined
variable. You should either define the function or remove this line from the
test.

[Peter Beverloo, 2015/09/22 16:19:50]

You seem to have missed this?

[mcasas, 2015/09/22 16:35:12]

Ouch yes - sorry, it was a comment on the first PS and missed it
totally.

It was, indeed, a change lost in the branch-off-branch and cherry
picking, since I'm working on this test in parallel. The idea was to
have an "unexpected" onStop leading the test to fail, and an
"expected" onStop, being triggered after calling recorder.stop(),
which was expected and needed for the test to pass.

I should have bundled these changes in a separate CL, but thought
they'd be innocuous -since the test is disabled- and meaningful
-someone might read the code- enough to bundle them in.
them in 

+    recorder.stop();
 });
 
 recorderOnStop = test.step_func(function() {
+    test.done();
+});
+
+recorderOnStopUnexpected = test.step_func(function() {
     assert_unreached('Recording stopped.');
 });
 
+recorderOnError = test.step_func(function() {
+    assert_unreached('Recording error.');
+});
+
 gotStream = test.step_func(function(stream) {
     assert_equals(stream.getAudioTracks().length, 0);
     assert_equals(stream.getVideoTracks().length, 1);
@@ -32,7 +46,8 @@ gotStream = test.step_func(function(stream) {
 
     assert_equals(recorder.state, "inactive");
     recorder.ondataavailable = recorderOnDataAvailable;
-    recorder.onstop = recorderOnStop;
+    recorder.onstop = recorderOnStopUnexpected;
+    recorder.onerror = recorderOnError;
     recorder.start();
 
     assert_equals(recorder.state, "recording");