Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 135483002: aura: Fix a couple of issues related to held touch events. (Closed)

Created:
6 years, 11 months ago by sadrul
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

aura: Fix a couple of issues related to held touch events. * The held touch event's location should be in the root-window's coordinate (and not in the target's coordinate system). * When a touch-move event is 'held' instead of being dispatched, do not generate any gesture events from it. BUG=332963 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244537

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -48 lines) Patch
M ui/aura/root_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/root_window.cc View 1 3 chunks +13 lines, -12 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 14 chunks +99 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 11 months ago (2014-01-11 14:12:41 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-13 14:29:45 UTC) #2
sadrul
6 years, 11 months ago (2014-01-13 18:20:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r244537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698